[webkit-reviews] review granted: [Bug 218646] Use address diversified PAC to ensure the integrity of opcode maps. : [Attachment 413403] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 218646: Use address diversified PAC to ensure the integrity of opcode maps.
https://bugs.webkit.org/show_bug.cgi?id=218646

Attachment 413403: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=413403&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 413403
  --> https://bugs.webkit.org/attachment.cgi?id=413403
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=413403&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +

Yes. For example, we need to add bunch of wasm opcodes more. And this soon
exceeds the size of JSC::Config even in macOS. And increasing this size
immediately becomes 1% regression in RAMiciation.