[webkit-reviews] review denied: [Bug 218529] [GPU Process] Use the Ref counting of ImageBuffer to control its life cycle in Web Process and GPU Process : [Attachment 413361] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 17:46:10 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 218529: [GPU Process] Use the Ref counting of ImageBuffer to control its
life cycle in Web Process and GPU Process
https://bugs.webkit.org/show_bug.cgi?id=218529

Attachment 413361: Patch

https://bugs.webkit.org/attachment.cgi?id=413361&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 413361
  --> https://bugs.webkit.org/attachment.cgi?id=413361
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413361&action=review

> Source/WebCore/platform/graphics/GraphicsContext.cpp:815
> +    if (m_impl && image.renderingResourceIdentifier()) {

image.renderingResourceIdentifier should not change behavior.


More information about the webkit-reviews mailing list