[webkit-reviews] review granted: [Bug 218635] window.event should not be affected by nodes moving post-dispatch : [Attachment 413355] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 16:28:07 PST 2020


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 218635: window.event should not be affected by nodes moving post-dispatch
https://bugs.webkit.org/show_bug.cgi?id=218635

Attachment 413355: Patch

https://bugs.webkit.org/attachment.cgi?id=413355&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 413355
  --> https://bugs.webkit.org/attachment.cgi?id=413355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413355&action=review

r=me

> Source/WebCore/dom/Event.cpp:134
> +    m_currentTargetIsInShadowTree =
isInShadowTree.valueOr(is<Node>(currentTarget) &&
downcast<Node>(*currentTarget).isInShadowTree());

Fancy!


More information about the webkit-reviews mailing list