[webkit-reviews] review granted: [Bug 218052] [macOS] Set application information in the Networking process on behalf of the WebContent process : [Attachment 413317] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 218052: [macOS] Set application information in the Networking process on
behalf of the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=218052

Attachment 413317: Patch

https://bugs.webkit.org/attachment.cgi?id=413317&action=review




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 413317
  --> https://bugs.webkit.org/attachment.cgi?id=413317
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413317&action=review

r=me

> Source/WTF/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=218052

<rdar://problem/70586405>

> Source/WebCore/PAL/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=218052

<rdar://problem/70586405>

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=218052

rdar://problem/70586405

> Source/WebKit/NetworkProcess/mac/NetworkConnectionToWebProcessMac.mm:38
> +    if (!overrideDisplayName)

Do we override if 'overrideDisplayName' is an empty string? I think this code
will use a blank string for the name -- is that what we want?

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:687
> +	   WTFLogAlways("Unable to get audit token for self.");

Shouldn't we show the error # in this log message?