[webkit-reviews] review granted: [Bug 210469] Scroll snap specified on :root doesn't work : [Attachment 413330] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 210469: Scroll snap specified on :root doesn't work
https://bugs.webkit.org/show_bug.cgi?id=210469

Attachment 413330: Patch

https://bugs.webkit.org/attachment.cgi?id=413330&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 413330
  --> https://bugs.webkit.org/attachment.cgi?id=413330
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413330&action=review

> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:166
> +    const HashSet<const RenderBox*>& boxesWithScrollSnapPositions =
scrollingElementBox.view().boxesWithScrollSnapPositions();

auto

> Source/WebCore/rendering/RenderLayer.cpp:3595
> +    updateSnapOffsetsForScrollableArea(*this, *box, box->style(),
box->paddingBoxRect());

Does paddingBoxRect() do the right thing if scrollbars are visible? (e.g.
bottom snap with vertical and horizontal scrollbar)?