[webkit-reviews] review granted: [Bug 218599] Store WeakPtr<Frame> instead of Frame* : [Attachment 413247] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 08:11:29 PST 2020

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 218599: Store WeakPtr<Frame> instead of Frame*

Attachment 413247: Patch


--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 413247
  --> https://bugs.webkit.org/attachment.cgi?id=413247

View in context: https://bugs.webkit.org/attachment.cgi?id=413247&action=review

> Source/WebCore/bindings/js/WindowProxy.h:53
> +    WEBCORE_EXPORT AbstractFrame* frame() const;

Why not keeping it inline?

More information about the webkit-reviews mailing list