[webkit-reviews] review denied: [Bug 218565] [css-grid] Move tests grid-columns-rows-get-set-multiple and grid-content-sized-columns-resolution to WPT folder : [Attachment 413274] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has denied zsun at igalia.com's request
for review:
Bug 218565: [css-grid] Move tests grid-columns-rows-get-set-multiple and
grid-content-sized-columns-resolution to WPT folder
https://bugs.webkit.org/show_bug.cgi?id=218565

Attachment 413274: Patch

https://bugs.webkit.org/attachment.cgi?id=413274&action=review




--- Comment #4 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 413274
  --> https://bugs.webkit.org/attachment.cgi?id=413274
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413274&action=review

Thanks for doing this, just a minor change is required, the rest looks good to
me.

> LayoutTests/ChangeLog:7
> +

I'd add here a small comment, explaining that these tests have been moved
upstream in a Chromium change, linking the change or the WPT PR generated by
the change.

> LayoutTests/imported/w3c/ChangeLog:12
> +

I believe we miss a change in "css/css-grid/parsing/w3c-import.log" to include
the new tests.