[webkit-reviews] review granted: [Bug 218196] Web Inspector: REGRESSION(r266695): Sources: override banner is squished for large images : [Attachment 413233] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 218196: Web Inspector: REGRESSION(r266695): Sources: override banner is
squished for large images
https://bugs.webkit.org/show_bug.cgi?id=218196

Attachment 413233: Patch

https://bugs.webkit.org/attachment.cgi?id=413233&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 413233
  --> https://bugs.webkit.org/attachment.cgi?id=413233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413233&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +	   This is resolved by making sure the minimum dimensions of the image
containers are 0, so that the container can
> +	   be `flex-shrink`ed.

That's ... odd.  The fact that we have to add `min-width`/`min-height` really
feels like a bug :(

Could we use `flex-shrink`/`flex-grow` instead (maybe also on the banner node
too)?