[webkit-reviews] review denied: [Bug 218035] Web Inspector: Can't edit certain style rules on twitter.com (created by React Native StyleSheet) : [Attachment 413205] WIP

Wed Nov 4 14:02:12 PST 2020

Nikita Vasilyev <nvasilyev at apple.com> has denied  review:
Bug 218035: Web Inspector: Can't edit certain style rules on twitter.com
(created by React Native StyleSheet)
https://bugs.webkit.org/show_bug.cgi?id=218035

Attachment 413205: WIP

https://bugs.webkit.org/attachment.cgi?id=413205&action=review

--- Comment #8 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 413205

  --> https://bugs.webkit.org/attachment.cgi?id=413205&action=review

WIP

This diff has front-end changes necessary to make CSS properties editable.
However, I discovered that the backend part is broken, too :(

```
<style id="style_element"></style>
<script>
style_element.sheet.insertRule("body {color: green}", 0);
</script>
```

With this WIP applied, inspect <body> and change the color from "green" to
"blue". The following error will happen:

[Error] Error saving style: – "NotFoundError"
	styleTextDidChange (CSSStyleDeclaration.js:238)

The error is coming from the backend. Specifically,
`target.CSSAgent.setStyleText(style.id, text, didSetStyleText)` can't seem to
be able to find and update dynamically created styles.