[webkit-reviews] review granted: [Bug 218382] WebDriver: session can have more than one active input source of the same type : [Attachment 412737] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 11:41:15 PST 2020


Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 218382: WebDriver: session can have more than one active input source of
the same type
https://bugs.webkit.org/show_bug.cgi?id=218382

Attachment 412737: Patch

https://bugs.webkit.org/attachment.cgi?id=412737&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 412737
  --> https://bugs.webkit.org/attachment.cgi?id=412737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412737&action=review

r=me, good catch.

> Source/WebDriver/ChangeLog:8
> +	   Only send to the browser the list of input sources actually used by
the action sequence.

I checked, and this is indeed what safaridriver already does on its side.


More information about the webkit-reviews mailing list