[webkit-reviews] review denied: [Bug 218566] JSC build fails on Big Sur 11.0.1 beta : [Attachment 413161] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Sergey Rubanov
<chi187 at gmail.com>'s request for review:
Bug 218566: JSC build fails on Big Sur 11.0.1 beta
https://bugs.webkit.org/show_bug.cgi?id=218566

Attachment 413161: Patch

https://bugs.webkit.org/attachment.cgi?id=413161&action=review




--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 413161
  --> https://bugs.webkit.org/attachment.cgi?id=413161
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413161&action=review

r- for the cmake minimum version change.

> CMakeLists.txt:9
> -cmake_minimum_required(VERSION 3.10)
> +cmake_minimum_required(VERSION 3.18)

Is this needed to use the find_library() function?

I only have 3.17.x installed on my macOS 10.15.6 system, so I think this would
break (Apple) folks using CMake on macOS.