[webkit-reviews] review denied: [Bug 218546] window.event may get set on wrong global when dispatching an event : [Attachment 413165] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 218546: window.event may get set on wrong global when dispatching an event
https://bugs.webkit.org/show_bug.cgi?id=218546

Attachment 413165: Patch

https://bugs.webkit.org/attachment.cgi?id=413165&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 413165
  --> https://bugs.webkit.org/attachment.cgi?id=413165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413165&action=review

> Source/WebCore/ChangeLog:9
> +	   'current event', stating that global the 'listener callbackâs
associated Realmâs global

that global the => that global is the

> Source/WebCore/bindings/js/JSDOMWindowBase.h:114
> +    Event* m_currentEvent { nullptr };

Can we use RefPtr here?

> Source/WebCore/bindings/js/JSErrorHandler.cpp:83
> +	   Event* savedEvent = nullptr;

Can we use RefPtr here?

> Source/WebCore/bindings/js/JSErrorHandler.cpp:86
> +	       jsFunctionWindow->currentEvent();

I think you meant to assign to savedEvent here? Seems like a bug. Might need a
new test.

> Source/WebCore/bindings/js/JSEventListener.cpp:166
> +    Event* savedEvent = nullptr;

Can we use RefPtr here?