[webkit-reviews] review requested: [Bug 218562] [GTK][Regression][2.30] Application cannot override drag&drop callbacks : [Attachment 413169] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 09:01:15 PST 2020


Milan Crha <mcrha at redhat.com> has asked  for review:
Bug 218562: [GTK][Regression][2.30] Application cannot override drag&drop
callbacks
https://bugs.webkit.org/show_bug.cgi?id=218562

Attachment 413169: proposed patch

https://bugs.webkit.org/attachment.cgi?id=413169&action=review




--- Comment #1 from Milan Crha <mcrha at redhat.com> ---
Created attachment 413169

  --> https://bugs.webkit.org/attachment.cgi?id=413169&action=review

proposed patch

This fixes it for me. Three changes are included, all are needed:

1) use g_signal_connect_after(), thus the descendants can get before that
callback, as it used to be when the d&d callbacks had been assigned as
GtkWidgetClass members;

2) update the inner m_drop context whenever it's different from the passed-in
context in the "drag-motion" handler, otherwise one cannot drag the second
time, because the "drag-leave" was not called (it is not called here);

3) in the DropTarget::didPerformAction() always call gdk_drag_status(),
otherwise the drag can look like being frozen.


More information about the webkit-reviews mailing list