[webkit-reviews] review granted: [Bug 218558] WKContextView might get KVO notifications it doesn't expect : [Attachment 413154] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 218558: WKContextView might get KVO notifications it doesn't expect
https://bugs.webkit.org/show_bug.cgi?id=218558

Attachment 413154: Patch

https://bugs.webkit.org/attachment.cgi?id=413154&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 413154
  --> https://bugs.webkit.org/attachment.cgi?id=413154
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413154&action=review

> Source/WebKit/ChangeLog:3
> +	   WKContextView might get KVO notifications it doesn't expect

I think the title means WKContentView

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:739
> -    [self.layer addObserver:self forKeyPath:@"transform"
options:NSKeyValueObservingOptionInitial context:nil];
> +    [self.layer addObserver:self forKeyPath:@"transform"
options:NSKeyValueObservingOptionInitial
context:WKContentViewKVOTransformContext];

Should we use the context in the deregistration too? I feel like there is some
documented benefit.