[webkit-reviews] review granted: [Bug 217542] REGRESSION(r268161?): [ macOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/processing-after-resume.https.html is a flaky failure : [Attachment 413068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 03:04:26 PST 2020

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217542: REGRESSION(r268161?): [ macOS ]
ce/processing-after-resume.https.html is a flaky failure

Attachment 413068: Patch


--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 413068
  --> https://bugs.webkit.org/attachment.cgi?id=413068

View in context: https://bugs.webkit.org/attachment.cgi?id=413068&action=review

> Source/WebCore/ChangeLog:13
> +	   still increase a bit, a short while after the suspend promise has
been resolved. To address the issue, we now to a round


> Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp:132
> +	   dispatchToRenderThread(WTFMove(callCompletionHandlerOnMainThread));

dispatchToRenderThread takes a function not a completion handler.
Should we make it take a CompletionHandler? It seems it should always call the
function in normal cases.

More information about the webkit-reviews mailing list