[webkit-reviews] review granted: [Bug 218539] Link against the ANGLE Shared Library : [Attachment 413115] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 16:07:06 PST 2020

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 218539: Link against the ANGLE Shared Library

Attachment 413115: Patch


--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 413115
  --> https://bugs.webkit.org/attachment.cgi?id=413115

View in context: https://bugs.webkit.org/attachment.cgi?id=413115&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:43

"Embedded" reads like old-school "mobile" to me, but I get that you mean
"inside". Alas. I think it's fine.

> Source/WebCore/Configurations/WebCore.xcconfig:72
> +WK_ANGLE_LDFLAGS = -weak-lANGLE-shared;

Is this ... really the right syntax? It looks super weird!

More information about the webkit-reviews mailing list