[webkit-reviews] review granted: [Bug 218405] [macOS] System sounds should be played in the UI process : [Attachment 412932] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 218405: [macOS] System sounds should be played in the UI process
https://bugs.webkit.org/show_bug.cgi?id=218405

Attachment 412932: Patch

https://bugs.webkit.org/attachment.cgi?id=412932&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 412932
  --> https://bugs.webkit.org/attachment.cgi?id=412932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412932&action=review

I’m not sure that an object is the best way to pass a function pointer. Could
have used WTF::Function instead.

> Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.h:28
> +#include <wtf/text/WTFString.h>

I would think we’d include Forward.h here.

> Source/WebKit/WebProcess/WebSystemSoundDelegate.h:32
> +class WebSystemSoundDelegate : public WebCore::SystemSoundDelegate {

final

> Source/WebKit/WebProcess/WebSystemSoundDelegate.h:35
> +    void systemBeep() override;

final