[webkit-reviews] review granted: [Bug 217735] [GPU Process] Enable Document based ImageBitmap and OffscreenCanvas drawing to go through GPU : [Attachment 413006] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 10:15:20 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 217735: [GPU Process] Enable Document based ImageBitmap and OffscreenCanvas
drawing to go through GPU
https://bugs.webkit.org/show_bug.cgi?id=217735

Attachment 413006: Patch

https://bugs.webkit.org/attachment.cgi?id=413006&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 413006
  --> https://bugs.webkit.org/attachment.cgi?id=413006
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413006&action=review

> Source/WebCore/ChangeLog:3
> +	   [GPU Process] Enable Document based ImageBitmap and OffscreenCanvas
drawing to go through GPU

"to go through GPU" -> "to use GPU Process rendering"

> Source/WebCore/html/ImageBitmap.cpp:84
> +    auto document = scriptExecutionContext.isDocument() ?
&downcast<Document>(scriptExecutionContext) : nullptr;
> +    auto hostWindow = (document && document->view() &&
document->view()->root()) ? document->view()->root()->hostWindow() : nullptr;

Does this code ever run in a Worker thread? If so, this is very non-threadsafe.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3808
>     
WebProcess::singleton().setUseGPUProcessForMedia(settings.useGPUProcessForMedia
Enabled());
> +   
WebProcess::singleton().setUseGPUProcessForCanvas(m_shouldRenderCanvasInGPUProc
ess);

Why are these two lines different?


More information about the webkit-reviews mailing list