[webkit-reviews] review denied: [Bug 218401] [GPU Process] Flush canvas displayList from doAfterUpdateRendering : [Attachment 412996] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 09:52:52 PST 2020

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Rini Patel
<rini_patel at apple.com>'s request for review:
Bug 218401: [GPU Process] Flush canvas displayList from doAfterUpdateRendering

Attachment 412996: Patch


--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 412996
  --> https://bugs.webkit.org/attachment.cgi?id=412996

View in context: https://bugs.webkit.org/attachment.cgi?id=412996&action=review

Almost there! Let's do one more round.

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:310
> +    bool needsPreparationForDisplay() const final { return true; }

This needs to also consult the buffer's shouldEagerlyFlush(), otherwise you've
changed the behavior at Document::canvasChanged().

> Source/WebCore/platform/graphics/ImageBuffer.h:71
> +    virtual bool shouldEagerlyFlush() { return false; }

I'm trying to think of a better name for this. How about

More information about the webkit-reviews mailing list