[webkit-reviews] review granted: [Bug 218516] Add helper methods to encode and decode IPC arguments as raw data : [Attachment 413061] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 218516: Add helper methods to encode and decode IPC arguments as raw data
https://bugs.webkit.org/show_bug.cgi?id=218516

Attachment 413061: Patch

https://bugs.webkit.org/attachment.cgi?id=413061&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 413061
  --> https://bugs.webkit.org/attachment.cgi?id=413061
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413061&action=review

r=me

> Source/WebKit/Platform/IPC/Encoder.cpp:76
> +    : m_messageName(static_cast<MessageName>(0))

If you just want some initialization, and you don't have a specific use for 0,
"m_messageName()" is probably better here.

> Source/WebKit/Platform/IPC/Encoder.h:104
> +    static RefPtr<WebCore::SharedBuffer> encodeObject(const T& object)

Not sure what distinction "encodeObject" intends to make here, in comparison to
Encoder's "encode" functions. Maybe this should just be called "encode"?