[webkit-reviews] review granted: [Bug 218468] Regression(r269227) imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash : [Attachment 412986] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 2 16:40:38 PST 2020


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 218468: Regression(r269227)
imported/w3c/web-platform-tests/service-workers/service-worker/referrer-topleve
l-script-fetch.https.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=218468

Attachment 412986: Patch

https://bugs.webkit.org/attachment.cgi?id=412986&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 412986
  --> https://bugs.webkit.org/attachment.cgi?id=412986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412986&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:116
> +		   auto* context = scriptExecutionContext();
> +		   if (!context)
> +		       return;
> +
> +		   auto registration =
ServiceWorkerRegistration::getOrCreate(*context, *this,
WTFMove(registrationData));

Not sure this needs a blank line.


More information about the webkit-reviews mailing list