[webkit-reviews] review granted: [Bug 218447] [Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa) : [Attachment 412963] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 2 14:56:24 PST 2020
Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 218447: [Testing] Match WebKitTestRunner and enable all "experimental"
features in DumpRenderTree (cocoa)
https://bugs.webkit.org/show_bug.cgi?id=218447
Attachment 412963: Patch
https://bugs.webkit.org/attachment.cgi?id=412963&action=review
--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 412963
--> https://bugs.webkit.org/attachment.cgi?id=412963
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412963&action=review
> Tools/DumpRenderTree/mac/DumpRenderTree.mm:901
> + [preferences setEncryptedMediaAPIEnabled:YES];
> + [preferences setGamepadsEnabled:YES];
> + [preferences setLinkPreloadEnabled:YES];
> + [preferences setMediaPreloadingEnabled:YES];
> + [preferences setColorFilterEnabled:YES];
What’s the significance of the ordering here? If there’s none, then I suggest
sorting.
More information about the webkit-reviews
mailing list