[webkit-reviews] review granted: [Bug 218442] Allow low latency H264 encoder in GPUProcess : [Attachment 412914] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 2 14:03:58 PST 2020

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 218442: Allow low latency H264 encoder in GPUProcess

Attachment 412914: Patch


--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 412914
  --> https://bugs.webkit.org/attachment.cgi?id=412914

View in context: https://bugs.webkit.org/attachment.cgi?id=412914&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:97
> +- (void)setLowLatency:(bool)isLowLatencyEnabled {

Nit: "isLowLatencyEnabled" sounds like a question, I would probably call the
parameter "lowLatencyEnabled", or even just "enabled"

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:99
> +	   return [m_h264Encoder

Nit: "return" is unnecessary

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:319
> +void setLocalEncoderLowLatency(LocalEncoder localEncoder, bool

Ditto about the parameter name from above.

More information about the webkit-reviews mailing list