[webkit-reviews] review canceled: [Bug 218315] WebKit should remove unused debug variant support : [Attachment 412943] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 2 12:50:35 PST 2020


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 218315: WebKit should remove unused debug variant support
https://bugs.webkit.org/show_bug.cgi?id=218315

Attachment 412943: Patch v2

https://bugs.webkit.org/attachment.cgi?id=412943&action=review




--- Comment #17 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 412943
  --> https://bugs.webkit.org/attachment.cgi?id=412943
Patch v2

FWIW, we use [config=Debug] in other places as well:

$ grep -l -r '\[config=Debug\]' Source Tools
Source/WebKit/SwiftOverlay/Configurations/Base.xcconfig
Source/WebKit/SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig
Source/ThirdParty/libwebrtc/Configurations/DebugRelease.xcconfig


More information about the webkit-reviews mailing list