[webkit-reviews] review requested: [Bug 217543] [ macOS ] webaudio/OfflineAudioContext/onstatechange.html is a flaky failure : [Attachment 412960] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has asked  for review:
Bug 217543: [ macOS ] webaudio/OfflineAudioContext/onstatechange.html is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217543

Attachment 412960: Patch

https://bugs.webkit.org/attachment.cgi?id=412960&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 412960
  --> https://bugs.webkit.org/attachment.cgi?id=412960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412960&action=review

> Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:105
> +	   callOnMainThread([this, result, currentSampleFrame =
m_currentSampleFrame, protectedThis = WTFMove(protectedThis)]() mutable {
> +	       context().postTask([this, protectedThis =
WTFMove(protectedThis), result, currentSampleFrame]() mutable {

Doesn’t seem like we need callOnMainThread if calling postTask. It already does
callOnMainThread.