[webkit-reviews] review denied: [Bug 218067] webkitpy: Add a --no-comment switch to webkit-patch land : [Attachment 412060] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 2 11:47:48 PST 2020
Ryosuke Niwa <rniwa at webkit.org> has denied Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 218067: webkitpy: Add a --no-comment switch to webkit-patch land
https://bugs.webkit.org/show_bug.cgi?id=218067
Attachment 412060: Patch
https://bugs.webkit.org/attachment.cgi?id=412060&action=review
--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 412060
--> https://bugs.webkit.org/attachment.cgi?id=412060
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412060&action=review
>> Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff.py:59
>> + self._tool.bugs.close_bug_as_fixed(bug_id)
>
> It's not great to close a bug without commenting.
> We should probably not close the bug or leave a comment regardless of the
option in this case.
r- because of this point.
More information about the webkit-reviews
mailing list