[webkit-reviews] review denied: [Bug 218401] [GPU Process] Flush canvas displayList from doAfterUpdateRendering : [Attachment 412939] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Rini Patel
<rini_patel at apple.com>'s request for review:
Bug 218401: [GPU Process] Flush canvas displayList from doAfterUpdateRendering
https://bugs.webkit.org/show_bug.cgi?id=218401

Attachment 412939: Patch

https://bugs.webkit.org/attachment.cgi?id=412939&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 412939
  --> https://bugs.webkit.org/attachment.cgi?id=412939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412939&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:375
> +#if ENABLE(GPU_PROCESS)
> +    if (m_context)
> +	   addObserver(document());
> +#endif

This needs to be a runtime check not a compile-time check, and should only
happen when we make a remote image buffer.

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:2051
> +    if (buffer && buffer->renderingResourceIdentifier())

I don't think checking for a renderingResourceIdentifier is the right approach.
Maybe add ImageBuffer::flushContextAsync() and just call it always, then
specialize the remote image buffer to flush the display list etc.