[webkit-reviews] review granted: [Bug 218246] [GStreamer] Switch the ImageDecoder to decodebin3 : [Attachment 412734] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 218246: [GStreamer] Switch the ImageDecoder to decodebin3
https://bugs.webkit.org/show_bug.cgi?id=218246

Attachment 412734: Patch

https://bugs.webkit.org/attachment.cgi?id=412734&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 412734
  --> https://bugs.webkit.org/attachment.cgi?id=412734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412734&action=review

> Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:229
> +int
ImageDecoderGStreamer::InnerDecoder::decodebinSelectStreamCallback(GstElement*,
GstStreamCollection*, GstStream* stream, ImageDecoderGStreamer::InnerDecoder*
decoder)
> +{
> +    return decoder->selectStream(stream);
> +}

I would use a lambda instead of this.

> Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:244
> +    int result = (gst_stream_get_stream_type(stream) &
GST_STREAM_TYPE_VIDEO) ? 1 : 0;

You don't need the () around gst_stream_get_stream_type(stream) &
GST_STREAM_TYPE_VIDEO