[webkit-reviews] review requested: [Bug 212562] Consider a Thread Specific Cache for AssemblerBuffers : [Attachment 400696] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 30 23:01:22 PDT 2020

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 212562: Consider a Thread Specific Cache for AssemblerBuffers

Attachment 400696: Updated patch


--- Comment #5 from Michael Saboff <msaboff at apple.com> ---
Created attachment 400696

  --> https://bugs.webkit.org/attachment.cgi?id=400696&action=review

Updated patch

> > Source/JavaScriptCore/assembler/AssemblerBuffer.h:202
> > +		 *threadSpecific = WTFMove(m_storage);
> Worth trying just WTFMoving if the destination is clear. Or letting the
> bigger buffer win.

Made that change and it appears to improve performance.

> > Source/JavaScriptCore/assembler/AssemblerBuffer.h:324
> > +		     void* ptr = static_cast<AssemblerData*>(threadSpecific);
> I’m not sure that this placement new thing is the canonical way to
> initialize a thread specific?

Copied this from a similar recent patch.

Speculative fix for the JSC i386 build failure.

More information about the webkit-reviews mailing list