[webkit-reviews] review denied: [Bug 178009] Null pointer crash under JSC::Lexer<wchar_t>::setCode. : [Attachment 323016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 30 19:50:24 PDT 2020

Maciej Stachowiak <mjs at apple.com> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 178009: Null pointer crash under JSC::Lexer<wchar_t>::setCode.

Attachment 323016: Patch


--- Comment #6 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 323016
  --> https://bugs.webkit.org/attachment.cgi?id=323016

Even though this patch still builds and seems to pass tests, per prior
comments, it seems like if there is a bug here it should be fixed at a higher
level. m_codeEnd should also be null when m_code_is, so m_code shouldn't be
less than.

More information about the webkit-reviews mailing list