[webkit-reviews] review granted: [Bug 176576] check-webkit-style shouldn't check *Prefix.cpp for [build/include_order] : [Attachment 320220] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 30 19:44:37 PDT 2020


Maciej Stachowiak <mjs at apple.com> has granted Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 176576: check-webkit-style shouldn't check *Prefix.cpp for
[build/include_order]
https://bugs.webkit.org/show_bug.cgi?id=176576

Attachment 320220: Patch

https://bugs.webkit.org/attachment.cgi?id=320220&action=review




--- Comment #3 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 320220
  --> https://bugs.webkit.org/attachment.cgi?id=320220
Patch

Seems like a good change. Unfortunately, this patch itself fails the style
checker. Seems like everything in this file would fail the rule, so not sure
why. r=me but please update fo the style checker issue before landing.


More information about the webkit-reviews mailing list