[webkit-reviews] review denied: [Bug 169601] Fix uninitialized public members in Webkit2/Shared : [Attachment 304793] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 30 18:08:42 PDT 2020


Maciej Stachowiak <mjs at apple.com> has denied Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 169601: Fix uninitialized public members in Webkit2/Shared
https://bugs.webkit.org/show_bug.cgi?id=169601

Attachment 304793: Patch

https://bugs.webkit.org/attachment.cgi?id=304793&action=review




--- Comment #7 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 304793
  --> https://bugs.webkit.org/attachment.cgi?id=304793
Patch

Where these fields found to ever actually be used uninitialized, or is this a
"just in case"? I think on the whole it's better to initialize these.
Unfortunately, this patch no longer applies, so r- for current version.


More information about the webkit-reviews mailing list