[webkit-reviews] review granted: [Bug 212572] Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platforms that consult touch-action for event handling : [Attachment 400675] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 212572: Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant
for platforms that consult touch-action for event handling
https://bugs.webkit.org/show_bug.cgi?id=212572

Attachment 400675: Patch

https://bugs.webkit.org/attachment.cgi?id=400675&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 400675
  --> https://bugs.webkit.org/attachment.cgi?id=400675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400675&action=review

> Source/WTF/wtf/PlatformEnable.h:491
> +#if !defined(ENABLE_TOUCH_ACTION_REGIONS)
> +#define ENABLE_TOUCH_ACTION_REGIONS 0
> +#endif

Not sure why we have to do this when the default is 0, because
!ENABLE_TOUCH_ACTION_REGIONS and !defined(ENABLE_TOUCH_ACTION_REGIONS) is the
same as far as the ENABLE() macro is concerned.