[webkit-reviews] review granted: [Bug 212555] Add debug alerts to xhr tests : [Attachment 400636] Patch

Fri May 29 17:26:04 PDT 2020

Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 212555: Add debug alerts to xhr tests
https://bugs.webkit.org/show_bug.cgi?id=212555

Attachment 400636: Patch

https://bugs.webkit.org/attachment.cgi?id=400636&action=review

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 400636
  --> https://bugs.webkit.org/attachment.cgi?id=400636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400636&action=review

I would suggest console.log. alert() has interesting runloop scheduling
consequences even in DRT/WKTR where it's short circuited.

> LayoutTests/imported/w3c/web-platform-tests/xhr/event-error-order.sub.html:1
> -ï»¿<!DOCTYPE html>
> +<!DOCTYPE html>

Curious. I don't think that we are supposed to remove BOM from imported tests?
Can revert it all together later, I guess.