[webkit-reviews] review granted: [Bug 212551] [Cocoa] Improve logging quality for non-ephemeral sessions : [Attachment 400637] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 29 17:13:20 PDT 2020

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 212551: [Cocoa] Improve logging quality for non-ephemeral sessions

Attachment 400637: Patch


--- Comment #8 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 400637
  --> https://bugs.webkit.org/attachment.cgi?id=400637

View in context: https://bugs.webkit.org/attachment.cgi?id=400637&action=review

r=me if you add the #if HAVE(LOGGING_PRIVACY_LEVEL)/#endif guard.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1033
> +    auto loggingPrivacyLevel = nw_context_privacy_level_sensitive;

This still needs #if HAVE(LOGGING_PRIVACY_LEVEL)/#endif guard otherwise it will
be an unused variable.

It should result in a build failure, except I think we have that warning
disabled on the WebKit project.

More information about the webkit-reviews mailing list