[webkit-reviews] review denied: [Bug 212551] [Cocoa] Improve logging quality for non-ephemeral sessions : [Attachment 400635] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 212551: [Cocoa] Improve logging quality for non-ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=212551

Attachment 400635: Patch

https://bugs.webkit.org/attachment.cgi?id=400635&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 400635
  --> https://bugs.webkit.org/attachment.cgi?id=400635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400635&action=review

r- due to build failures.

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:80
> +#ifndef NW_CONTEXT_HAS_PRIVACY_LEVEL_SILENT
> +#define NW_CONTEXT_HAS_PRIVACY_LEVEL_SILENT	  1
> +#endif

Why is this needed separately from HAVE(LOGGING_PRIVACY_LEVEL)?

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1033
> +    auto loggingPrivacyLevel = nw_context_privacy_level_sensitive;

Need to protect this with #if HAVE(LOGGING_PRIVACY_LEVEL)/#endif.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1041
> +#if defined(NW_CONTEXT_HAS_PRIVACY_LEVEL_SILENT)
> +	   loggingPrivacyLevel = nw_context_privacy_level_silent;
> +#endif

Why not protect this with #if HAVE(LOGGING_PRIVACY_LEVEL)/#endif?