[webkit-reviews] review granted: [Bug 212546] REGRESSION (r260306): Compatibility issue leading to crash on macOS games : [Attachment 400620] Patch v1

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 212546: REGRESSION (r260306): Compatibility issue leading to crash on macOS
games
https://bugs.webkit.org/show_bug.cgi?id=212546

Attachment 400620: Patch v1

https://bugs.webkit.org/attachment.cgi?id=400620&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 400620
  --> https://bugs.webkit.org/attachment.cgi?id=400620
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=400620&action=review

r=me

>> Source/WebKitLegacy/mac/WebView/WebView.mm:569
>> +	id _defaultTarget;
> 
> Should I proactively change these to __unsafe_unretained to future-proof a
possible mistake during ARC conversion?

Yes, that seems like a good idea.