[webkit-reviews] review granted: [Bug 212538] We need to properly model heap ranges of Delete in DFG/B3 : [Attachment 400607] patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 212538: We need to properly model heap ranges of Delete in DFG/B3
https://bugs.webkit.org/show_bug.cgi?id=212538

Attachment 400607: patch

https://bugs.webkit.org/attachment.cgi?id=400607&action=review




--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 400607
  --> https://bugs.webkit.org/attachment.cgi?id=400607
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400607&action=review

R=me with comment.

> Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:159
> +    macro(JSCell_header_and_named_properties, 0) \

This should be an abstract heap, not an abstract field, since the offset is not
meaningful.