[webkit-reviews] review granted: [Bug 212486] Use correct encoding when converting a WTF::URL to CFURLRef : [Attachment 400529] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 29 10:11:59 PDT 2020

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 212486: Use correct encoding when converting a WTF::URL to CFURLRef

Attachment 400529: Patch


--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 400529
  --> https://bugs.webkit.org/attachment.cgi?id=400529

View in context: https://bugs.webkit.org/attachment.cgi?id=400529&action=review

> Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:642
> +    result = adoptCF(CFURLCreateAbsoluteURLWithBytes(nullptr,
reinterpret_cast<const UInt8*>(urlBytes.data()), urlBytes.size(),
kCFStringEncodingASCII, baseURL.get(), true));

Should we add a check that none of the bytes have their high bit set, and
return false if so?

> Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:221
> +    EXPECT_STREQ([[url4 absoluteString] UTF8String], "%C3%82%C2%B6");

Looks like this test is failing on the bot; please fix before landing.

More information about the webkit-reviews mailing list