[webkit-reviews] review granted: [Bug 212516] [WebXR] WebXRSystem::unregisterSimulatedXRDeviceForTesting() ASSERTs in m_immersiveDevices.contains(device) : [Attachment 400562] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 29 03:24:10 PDT 2020
Zan Dobersek <zan at falconsigh.net> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 212516: [WebXR] WebXRSystem::unregisterSimulatedXRDeviceForTesting()
ASSERTs in m_immersiveDevices.contains(device)
https://bugs.webkit.org/show_bug.cgi?id=212516
Attachment 400562: Patch
https://bugs.webkit.org/attachment.cgi?id=400562&action=review
--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 400562
--> https://bugs.webkit.org/attachment.cgi?id=400562
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=400562&action=review
> Source/WebCore/Modules/webxr/WebXRSystem.cpp:457
> + UNUSED_VARIABLE(removed);
> + ASSERT(removed || m_inlineXRDevice == &device);
Can be folded into ASSERT_UNUSED.
More information about the webkit-reviews
mailing list