[webkit-reviews] review granted: [Bug 176119] [GTK][WPE] API for WebView audio mute support : [Attachment 400268] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 29 02:52:15 PDT 2020
Carlos Garcia Campos <cgarcia at igalia.com> has granted Jan-Michael Brummer
<jan.brummer at tabos.org>'s request for review:
Bug 176119: [GTK][WPE] API for WebView audio mute support
https://bugs.webkit.org/show_bug.cgi?id=176119
Attachment 400268: Patch
https://bugs.webkit.org/attachment.cgi?id=400268&action=review
--- Comment #60 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 400268
--> https://bugs.webkit.org/attachment.cgi?id=400268
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=400268&action=review
> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:1279
> + * It may still be playing, i.e. WebKitWebView:is-playing-audio may be
%TRUE.
#WebKitWebView:is-playing-audio
> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:3207
> + * webkit_web_view_is_muted:
Since this is a getter property. it should be webkit_web_view_get_is_muted
More information about the webkit-reviews
mailing list