[webkit-reviews] review granted: [Bug 212508] Avoid unnessecary sync IPC messages when togging the callout bar for selections. : [Attachment 400537] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 212508: Avoid unnessecary sync IPC messages when togging the callout bar
for selections.
https://bugs.webkit.org/show_bug.cgi?id=212508

Attachment 400537: Patch

https://bugs.webkit.org/attachment.cgi?id=400537&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 400537
  --> https://bugs.webkit.org/attachment.cgi?id=400537
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400537&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2566
> +		   if (!_page->editorState().selectionIsRange)
> +		       return NO;
> +		   if ([self _pointIsInsideSelectionRect:point
outBoundingRect:nil])
> +		       return YES;
> +		   return NO;

Nit - I would just write this `return [self _pointIsInsideSelectionRect:point
outBoundingRect:nil];`.