[webkit-reviews] review granted: [Bug 212476] [Apple Pay] Buttons render with a corner radius of PKApplePayButtonDefaultCornerRadius even when explicitly specifying "border-radius: 0px" : [Attachment 400481] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 212476: [Apple Pay] Buttons render with a corner radius of
PKApplePayButtonDefaultCornerRadius even when explicitly specifying
"border-radius: 0px"
https://bugs.webkit.org/show_bug.cgi?id=212476

Attachment 400481: Patch

https://bugs.webkit.org/attachment.cgi?id=400481&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 400481
  --> https://bugs.webkit.org/attachment.cgi?id=400481
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400481&action=review

> Source/WebCore/style/StyleBuilderCustom.h:127
> +    // FIXME: Teach makeprop.pl to generate setters for hasExplicitlySet*
flags

Yes please. Doing this manually is bit silly.

Also we might want to track the cascade level instead (so property can be set
on UA sheet without being considered 'explicitly set').