[webkit-reviews] review granted: [Bug 212407] [WebXR] Implement XRSession::requestReferenceSpace() : [Attachment 400331] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 212407: [WebXR] Implement XRSession::requestReferenceSpace()
https://bugs.webkit.org/show_bug.cgi?id=212407

Attachment 400331: Patch

https://bugs.webkit.org/attachment.cgi?id=400331&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 400331
  --> https://bugs.webkit.org/attachment.cgi?id=400331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400331&action=review

> Source/WebCore/Modules/webxr/WebXRBoundedReferenceSpace.h:42
> +    static Ref<WebXRBoundedReferenceSpace> create(ScriptExecutionContext*,
WebXRSession&, XRReferenceSpaceType);

Can we use a Document& and a Ref<WebXRSession>&&?

> Source/WebCore/Modules/webxr/WebXRSession.cpp:88
> +bool WebXRSession::referenceSpaceIsSupported(const XRReferenceSpaceType&
type) const

s/const XRReferenceSpaceType& type/XRReferenceSpaceType type/

> Source/WebCore/Modules/webxr/WebXRSession.cpp:128
> +void WebXRSession::requestReferenceSpace(const XRReferenceSpaceType& type,
RequestReferenceSpacePromise&& promise)

s/const XRReferenceSpaceType& type/XRReferenceSpaceType type/

> Source/WebCore/Modules/webxr/WebXRSession.cpp:132
> +    scriptExecutionContext()->postTask([this, promise = WTFMove(promise),
type] (ScriptExecutionContext&) mutable {

scriptExecutionContext() might be null.
s/ScriptExecutionContext&/auto&/

> Source/WebCore/Modules/webxr/WebXRSession.cpp:149
> +	   promise.resolve(*referenceSpace);

referenceSpace.releaseNonNull()

> Source/WebCore/Modules/webxr/WebXRSpace.h:32
> +#include <wtf/IsoMalloc.h>

Why do we need this one?