[webkit-reviews] review granted: [Bug 212073] MediaPlayerPrivateMediaStreamAVFObjC should enqueue samples in a background thread : [Attachment 400437] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 212073: MediaPlayerPrivateMediaStreamAVFObjC should enqueue samples in a
background thread
https://bugs.webkit.org/show_bug.cgi?id=212073

Attachment 400437: Patch

https://bugs.webkit.org/attachment.cgi?id=400437&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 400437
  --> https://bugs.webkit.org/attachment.cgi?id=400437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400437&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLaye
r.mm:294
> +// Called on a background thread.
>  void LocalSampleBufferDisplayLayer::enqueueSample(MediaSample& sample)
>  {

Is this comment in the wrong place?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStrea
mAVFObjC.mm:250
> +    processNewVideoSample(sample, sample.videoRotation() != m_videoRotation
|| sample.videoMirrored() != m_videoMirrored);
> +    enqueueVideoSample(sample);

processNewVideoSample does its work on the main thread, but enqueueVideoSample
updates the layer and enqueues the sample immediately. What will happen if AVF
displays the sample before processNewVideoSample runs?