[webkit-reviews] review granted: [Bug 212319] [GTK4] Implement HTTP auth dialog : [Attachment 400321] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 28 06:29:10 PDT 2020


Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 212319: [GTK4] Implement HTTP auth dialog
https://bugs.webkit.org/show_bug.cgi?id=212319

Attachment 400321: Patch

https://bugs.webkit.org/attachment.cgi?id=400321&action=review




--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 400321
  --> https://bugs.webkit.org/attachment.cgi?id=400321
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400321&action=review

Awesome!

> Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:145
>      gtk_widget_set_can_default(button, TRUE);

Isn't there an alternative for this on GTK4?


More information about the webkit-reviews mailing list