[webkit-reviews] review granted: [Bug 212441] [WPE][GTK] GVariant decoding must copy the serialized data : [Attachment 400395] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 212441: [WPE][GTK] GVariant decoding must copy the serialized data
https://bugs.webkit.org/show_bug.cgi?id=212441

Attachment 400395: Patch

https://bugs.webkit.org/attachment.cgi?id=400395&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 400395
  --> https://bugs.webkit.org/attachment.cgi?id=400395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400395&action=review

> Source/WebKit/ChangeLog:15
> +	   Bonus problem: the GVariant itself is leaked because we are missing
adoptGRef.

This is not true, g_variant_new returns a floating reference that shouldn't be
adopted.

> Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp:65
> +    return adoptGRef(g_variant_new_from_bytes(variantType.get(),
bytes.get(), FALSE));

Remove the adopt and fix the changelog before landing, please.