[webkit-reviews] review granted: [Bug 212441] [WPE][GTK] GVariant decoding must copy the serialized data : [Attachment 400395] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 28 00:51:32 PDT 2020

Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 212441: [WPE][GTK] GVariant decoding must copy the serialized data

Attachment 400395: Patch


--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 400395
  --> https://bugs.webkit.org/attachment.cgi?id=400395

View in context: https://bugs.webkit.org/attachment.cgi?id=400395&action=review

> Source/WebKit/ChangeLog:15
> +	   Bonus problem: the GVariant itself is leaked because we are missing

This is not true, g_variant_new returns a floating reference that shouldn't be

> Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp:65
> +    return adoptGRef(g_variant_new_from_bytes(variantType.get(),
bytes.get(), FALSE));

Remove the adopt and fix the changelog before landing, please.

More information about the webkit-reviews mailing list