[webkit-reviews] review granted: [Bug 212248] hasOwnProperty inside structure property for-in loop should use an opcode like has_structure_property but for hasOwnProperty : [Attachment 400364] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 27 16:04:04 PDT 2020


Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 212248: hasOwnProperty inside structure property for-in loop should use an
opcode like has_structure_property but for hasOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=212248

Attachment 400364: patch

https://bugs.webkit.org/attachment.cgi?id=400364&action=review




--- Comment #5 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 400364
  --> https://bugs.webkit.org/attachment.cgi?id=400364
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400364&action=review

r=me with comments.

> Source/JavaScriptCore/bytecode/BytecodeList.rb:1108
> +op :has_self_structure_property,

Wouldn't this normally be own? I guess we use the terms interchangeably though.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:5247
> +	   unsigned newTarget = std::get<1>(hasOwnPropertyTuple);

Like new.target? :P

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:5257
> +	   // disable peephole optimizations
> +	   generator.m_lastOpcodeID = op_end;

Nit: Can we make this a function on BytecodeGenerator?

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:5259
> +	   OpJmp::emit<OpcodeSize::Wide32>(&generator,
BoundLabel(static_cast<int>(newTarget) - static_cast<int>(branchInstIndex)));

Why does this have to be Wide32 if we are gonna Nop fill anyway?


More information about the webkit-reviews mailing list