[webkit-reviews] review granted: [Bug 156356] pageshow only fires the first time the back button is pressed : [Attachment 400372] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 156356: pageshow only fires the first time the back button is pressed
https://bugs.webkit.org/show_bug.cgi?id=156356

Attachment 400372: Patch

https://bugs.webkit.org/attachment.cgi?id=400372&action=review




--- Comment #11 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 400372
  --> https://bugs.webkit.org/attachment.cgi?id=400372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400372&action=review

> LayoutTests/ChangeLog:13
> +	   * fast/history/resources/page-cache-helper.html:

Comment?

>>
LayoutTests/http/tests/loading/main-resource-delegates-on-back-navigation-expec
ted.txt:38
>>
+http://127.0.0.1:8000/loading/main-resource-delegates-on-back-navigation.html
- didFinishLoading
> 
> This is a progression, it makes back/forward navigations more consistent with
regular navigations. For e.g., if you look at
LayoutTests/http/tests/loading/redirect-methods-expected.txt:
> """
> main frame - didFinishLoadForFrame
> http://127.0.0.1:8000/loading/redirect-methods.html - didFinishLoading
> """
> 
> We normally call didFinishLoadForFrame for the main frame *before* calling *
didFinishLoading*, which makes more sense.

Progressions of this kind are scary, as clients rely on quirks like this. But I
don't know what kind of testing we could to qualify the fix do besides
automated tests.