[webkit-reviews] review requested: [Bug 206431] [JSC] Add support for private class fields : [Attachment 400357] Patch v20

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 27 11:38:12 PDT 2020


Caitlin Potter (:caitp) <caitp at igalia.com> has asked  for review:
Bug 206431: [JSC] Add support for private class fields
https://bugs.webkit.org/show_bug.cgi?id=206431

Attachment 400357: Patch v20

https://bugs.webkit.org/attachment.cgi?id=400357&action=review




--- Comment #43 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Created attachment 400357

  --> https://bugs.webkit.org/attachment.cgi?id=400357&action=review

Patch v20

This version changes get_by_val_direct to get_private_name, adds get_by_id
style LLInt caching in metadata, and removes parts of the opcode that aren't
used (non-Symbol keyed operands). The rest of the patch is the same as it has
been since last week, as I've been told it had been under review


More information about the webkit-reviews mailing list